Fixes #3498 Turn off "Delay JS" option when Safe Mode is activated #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyperona
added
type: enhancement
remyperona
requested changes
Feb 12, 2021
|
@Tabrisrp Unit and Integration tests have been updated. |
remyperona
approved these changes
Feb 15, 2021
Mai-Saad
reviewed
Feb 16, 2021
There was a problem hiding this comment.
@GeekPress I have a couple of questions:
1- Do we need to display safe mode msg even if LazyLoad, File Optimization, Embeds, and CDN options are disabled?
2- Shall the safe mode option, delete the CDN name? (currently, it`s still there)
I don't know if adding an exclusion to detect all options turned off and not displaying it on this case worth it.
it's a good thing. If we delete it, it will require an extra step for the users to reconfigure their CDN. |
Mai-Saad
approved these changes
Feb 16, 2021
crystinutzaa
added a commit
that referenced
this pull request
Mar 4, 2021
* Update wording in first activation notice on the dashboard (PR #3583) Add automatically to match the description on the website. Also without it it sounds like WP Rocket would not know how to deal with the remaining 20%. * Fixes #3590 Imagify icon not shown in Chrome (PR #3591) * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Fixes #3498 Turn off "Delay JS" option when Safe Mode is activated (PR #3574) * Fixes #3454 Delay JS is not working if scrolling the page with the mouse wheel (PR #3573) * Closes #2839 Remove Age Verify plugin compatibility files (PR #3585) * Closes #1744 Show warning when PageSpeed Ninja is active (PR #3580) * Fixes #3238 Remove empty values in $purge_urls array (PR #3579) * Fixes #2777 Update text formatting in Rocket Analytics modal (#3598) * Closes #3113 Stop removing empty lines in the .htaccess (PR #3599) * Fixes #3605 Replace deprecated jQuery methods (PR #3606) * Translate /languages/rocket.pot in ru_RU translation completed for the source file '/languages/rocket.pot' on the 'ru_RU' language. * Closes #3564 Update minified filename structure to use query string instead of version in filename (PR #3595) * Fixes #3083 Update delay JS RegEx to ignore space inside script tags (PR #3587) * Updating AWX webhook url * Fixes #3576 Guard rocket_defer_inline_exclusions filter return when used by 3rd parties (PR #3582) * Fixes #2970 Add new post-type exclusion "cms_block" from CPCSS generation (PR #3550) * Closes #3423 Add preconnect tag for CDN URLs (#3463) * Add add_preconnect_cdn() method * Add integration test draft and notes. * Implement preconnect for non-crossorigin cdn-urls * Add fixture, adjust integration test * Revise forcorrect cdn urls, use crossorigin second * Run phpcbf * Update CDN preconnect testcases * Use agnostic scheme when not provided * Rerun phpcs * Clean dns-prefetch out of testcases :) * Add testcase/solution for `test/tests` * Closes #3539 Combine @import rules into the minified CSS files (PR #3603) * update plugin version * update pot file with changed strings * Translate /languages/rocket.pot in de_DE translation completed for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in fr_FR translation completed for the source file '/languages/rocket.pot' on the 'fr_FR' language. * Fix #3625 Contact form 7 stop working if dependency scripts are deferred after latest update (PR #3629) * exclude files from being deferred * add hooks script to the exclude list * update translations * Translate /languages/rocket.pot in tr_TR translation completed for the source file '/languages/rocket.pot' on the 'tr_TR' language. Co-authored-by: Presskopp <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Jonathan Buttigieg <[email protected]> Co-authored-by: Jorge <[email protected]> Co-authored-by: Natalia Drause <[email protected]> Co-authored-by: Caspar Green <[email protected]> Co-authored-by: Ahmed Saed <[email protected]> Co-authored-by: Vasilis Manthos <[email protected]> Co-authored-by: Albert Cintas <[email protected]> Co-authored-by: Sandy Figueroa <[email protected]> Co-authored-by: Soponar Cristina <[email protected]>
iCaspar
added a commit
that referenced
this pull request
Mar 23, 2021
* Update wording in first activation notice on the dashboard (PR #3583) Add automatically to match the description on the website. Also without it it sounds like WP Rocket would not know how to deal with the remaining 20%. * Fixes #3590 Imagify icon not shown in Chrome (PR #3591) * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Fixes #3498 Turn off "Delay JS" option when Safe Mode is activated (PR #3574) * Fixes #3454 Delay JS is not working if scrolling the page with the mouse wheel (PR #3573) * Closes #2839 Remove Age Verify plugin compatibility files (PR #3585) * Closes #1744 Show warning when PageSpeed Ninja is active (PR #3580) * Fixes #3238 Remove empty values in $purge_urls array (PR #3579) * Fixes #2777 Update text formatting in Rocket Analytics modal (#3598) * Closes #3113 Stop removing empty lines in the .htaccess (PR #3599) * Fixes #3605 Replace deprecated jQuery methods (PR #3606) * Translate /languages/rocket.pot in ru_RU translation completed for the source file '/languages/rocket.pot' on the 'ru_RU' language. * Closes #3564 Update minified filename structure to use query string instead of version in filename (PR #3595) * Fixes #3083 Update delay JS RegEx to ignore space inside script tags (PR #3587) * Updating AWX webhook url * Fixes #3576 Guard rocket_defer_inline_exclusions filter return when used by 3rd parties (PR #3582) * Fixes #2970 Add new post-type exclusion "cms_block" from CPCSS generation (PR #3550) * Closes #3423 Add preconnect tag for CDN URLs (#3463) * Add add_preconnect_cdn() method * Add integration test draft and notes. * Implement preconnect for non-crossorigin cdn-urls * Add fixture, adjust integration test * Revise forcorrect cdn urls, use crossorigin second * Run phpcbf * Update CDN preconnect testcases * Use agnostic scheme when not provided * Rerun phpcs * Clean dns-prefetch out of testcases :) * Add testcase/solution for `test/tests` * Closes #3539 Combine @import rules into the minified CSS files (PR #3603) * update plugin version * update pot file with changed strings * Translate /languages/rocket.pot in de_DE translation completed for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in fr_FR translation completed for the source file '/languages/rocket.pot' on the 'fr_FR' language. * Fix #3625 Contact form 7 stop working if dependency scripts are deferred after latest update (PR #3629) * exclude files from being deferred * add hooks script to the exclude list * update translations * Translate /languages/rocket.pot in tr_TR translation completed for the source file '/languages/rocket.pot' on the 'tr_TR' language. Co-authored-by: Presskopp <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Jonathan Buttigieg <[email protected]> Co-authored-by: Jorge <[email protected]> Co-authored-by: Natalia Drause <[email protected]> Co-authored-by: Caspar Green <[email protected]> Co-authored-by: Ahmed Saed <[email protected]> Co-authored-by: Vasilis Manthos <[email protected]> Co-authored-by: Albert Cintas <[email protected]> Co-authored-by: Sandy Figueroa <[email protected]> Co-authored-by: Soponar Cristina <[email protected]>
iCaspar
added a commit
that referenced
this pull request
Mar 23, 2021
* Update wording in first activation notice on the dashboard (PR #3583) Add automatically to match the description on the website. Also without it it sounds like WP Rocket would not know how to deal with the remaining 20%. * Fixes #3590 Imagify icon not shown in Chrome (PR #3591) * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Fixes #3498 Turn off "Delay JS" option when Safe Mode is activated (PR #3574) * Fixes #3454 Delay JS is not working if scrolling the page with the mouse wheel (PR #3573) * Closes #2839 Remove Age Verify plugin compatibility files (PR #3585) * Closes #1744 Show warning when PageSpeed Ninja is active (PR #3580) * Fixes #3238 Remove empty values in $purge_urls array (PR #3579) * Fixes #2777 Update text formatting in Rocket Analytics modal (#3598) * Closes #3113 Stop removing empty lines in the .htaccess (PR #3599) * Fixes #3605 Replace deprecated jQuery methods (PR #3606) * Translate /languages/rocket.pot in ru_RU translation completed for the source file '/languages/rocket.pot' on the 'ru_RU' language. * Closes #3564 Update minified filename structure to use query string instead of version in filename (PR #3595) * Fixes #3083 Update delay JS RegEx to ignore space inside script tags (PR #3587) * Updating AWX webhook url * Fixes #3576 Guard rocket_defer_inline_exclusions filter return when used by 3rd parties (PR #3582) * Fixes #2970 Add new post-type exclusion "cms_block" from CPCSS generation (PR #3550) * Closes #3423 Add preconnect tag for CDN URLs (#3463) * Add add_preconnect_cdn() method * Add integration test draft and notes. * Implement preconnect for non-crossorigin cdn-urls * Add fixture, adjust integration test * Revise forcorrect cdn urls, use crossorigin second * Run phpcbf * Update CDN preconnect testcases * Use agnostic scheme when not provided * Rerun phpcs * Clean dns-prefetch out of testcases :) * Add testcase/solution for `test/tests` * Closes #3539 Combine @import rules into the minified CSS files (PR #3603) * update plugin version * update pot file with changed strings * Translate /languages/rocket.pot in de_DE translation completed for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in fr_FR translation completed for the source file '/languages/rocket.pot' on the 'fr_FR' language. * Fix #3625 Contact form 7 stop working if dependency scripts are deferred after latest update (PR #3629) * exclude files from being deferred * add hooks script to the exclude list * update translations * Translate /languages/rocket.pot in tr_TR translation completed for the source file '/languages/rocket.pot' on the 'tr_TR' language. Co-authored-by: Presskopp <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Jonathan Buttigieg <[email protected]> Co-authored-by: Jorge <[email protected]> Co-authored-by: Natalia Drause <[email protected]> Co-authored-by: Caspar Green <[email protected]> Co-authored-by: Ahmed Saed <[email protected]> Co-authored-by: Vasilis Manthos <[email protected]> Co-authored-by: Albert Cintas <[email protected]> Co-authored-by: Sandy Figueroa <[email protected]> Co-authored-by: Soponar Cristina <[email protected]>
iCaspar
added a commit
that referenced
this pull request
Mar 26, 2021
* Add Unit test Warmup/APIClient * Add unit tests for Frontend APIClient * Update comments with @uses for AbstractAPI coverage * Fixes #3083 Update delay JS RegEx to ignore space inside script tags (PR #3587) * Updating AWX webhook url * Fixes #3576 Guard rocket_defer_inline_exclusions filter return when used by 3rd parties (PR #3582) * Fixes #2970 Add new post-type exclusion "cms_block" from CPCSS generation (PR #3550) * Closes #3423 Add preconnect tag for CDN URLs (#3463) * Add add_preconnect_cdn() method * Add integration test draft and notes. * Implement preconnect for non-crossorigin cdn-urls * Add fixture, adjust integration test * Revise forcorrect cdn urls, use crossorigin second * Run phpcbf * Update CDN preconnect testcases * Use agnostic scheme when not provided * Rerun phpcs * Clean dns-prefetch out of testcases :) * Add testcase/solution for `test/tests` * Closes #3539 Combine @import rules into the minified CSS files (PR #3603) * update plugin version * Fix #3625 Contact form 7 stop working if dependency scripts are deferred after latest update (PR #3629) * exclude files from being deferred * add hooks script to the exclude list * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in ru_RU translation completed for the source file '/languages/rocket.pot' on the 'ru_RU' language. * update pot file with changed strings * Translate /languages/rocket.pot in de_DE translation completed for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in fr_FR translation completed for the source file '/languages/rocket.pot' on the 'fr_FR' language. * update translations * Translate /languages/rocket.pot in tr_TR translation completed for the source file '/languages/rocket.pot' on the 'tr_TR' language. * Exclude googleoptimize.com from minify/combine JS (PR #3609) * Exclude www.idxhome.com from combine/defer JS (#3619) * Exclude wcpv_registration_local from combine JS (PR #3634) * Add additional inline JS exclusions from combine JS (PR #3638) * Closes #2883 UI improvement for Never Cache URL placeholder (PR #3631) * Bump elliptic from 6.5.3 to 6.5.4 (PR #3650) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixes #3528 Add AMP query string to cached query strings when activating the plugin (PR #3613) * Tiered Pricing Table for WooCommerce nonce action exclusion (PR #3652) * Closes #2812 Add new filter to rewrite srcset to the CDN (PR #3648) * Fixes #2041 CDN: prevent incorrect URL on srcset with duplicated relative URLS (PR #3615) * Fixes #3114 Apply font-display:swap to CPCSS (PR #3633) * Fixes #3073 Remove content from attributes list for WebP conversion (PR #3607) * Fixes #3394 PHP notice in Update_Subscriber::disable_auto_updates() (PR #3632) * update version to 3.8.7 * v3.8.6 (#3623) * Update wording in first activation notice on the dashboard (PR #3583) Add automatically to match the description on the website. Also without it it sounds like WP Rocket would not know how to deal with the remaining 20%. * Fixes #3590 Imagify icon not shown in Chrome (PR #3591) * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Fixes #3498 Turn off "Delay JS" option when Safe Mode is activated (PR #3574) * Fixes #3454 Delay JS is not working if scrolling the page with the mouse wheel (PR #3573) * Closes #2839 Remove Age Verify plugin compatibility files (PR #3585) * Closes #1744 Show warning when PageSpeed Ninja is active (PR #3580) * Fixes #3238 Remove empty values in $purge_urls array (PR #3579) * Fixes #2777 Update text formatting in Rocket Analytics modal (#3598) * Closes #3113 Stop removing empty lines in the .htaccess (PR #3599) * Fixes #3605 Replace deprecated jQuery methods (PR #3606) * Translate /languages/rocket.pot in ru_RU translation completed for the source file '/languages/rocket.pot' on the 'ru_RU' language. * Closes #3564 Update minified filename structure to use query string instead of version in filename (PR #3595) * Fixes #3083 Update delay JS RegEx to ignore space inside script tags (PR #3587) * Updating AWX webhook url * Fixes #3576 Guard rocket_defer_inline_exclusions filter return when used by 3rd parties (PR #3582) * Fixes #2970 Add new post-type exclusion "cms_block" from CPCSS generation (PR #3550) * Closes #3423 Add preconnect tag for CDN URLs (#3463) * Add add_preconnect_cdn() method * Add integration test draft and notes. * Implement preconnect for non-crossorigin cdn-urls * Add fixture, adjust integration test * Revise forcorrect cdn urls, use crossorigin second * Run phpcbf * Update CDN preconnect testcases * Use agnostic scheme when not provided * Rerun phpcs * Clean dns-prefetch out of testcases :) * Add testcase/solution for `test/tests` * Closes #3539 Combine @import rules into the minified CSS files (PR #3603) * update plugin version * update pot file with changed strings * Translate /languages/rocket.pot in de_DE translation completed for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in fr_FR translation completed for the source file '/languages/rocket.pot' on the 'fr_FR' language. * Fix #3625 Contact form 7 stop working if dependency scripts are deferred after latest update (PR #3629) * exclude files from being deferred * add hooks script to the exclude list * update translations * Translate /languages/rocket.pot in tr_TR translation completed for the source file '/languages/rocket.pot' on the 'tr_TR' language. Co-authored-by: Presskopp <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Jonathan Buttigieg <[email protected]> Co-authored-by: Jorge <[email protected]> Co-authored-by: Natalia Drause <[email protected]> Co-authored-by: Caspar Green <[email protected]> Co-authored-by: Ahmed Saed <[email protected]> Co-authored-by: Vasilis Manthos <[email protected]> Co-authored-by: Albert Cintas <[email protected]> Co-authored-by: Sandy Figueroa <[email protected]> Co-authored-by: Soponar Cristina <[email protected]> * Fixes #3658 Force the PSR Container dependency to v1.0.0 (PR #3660) * Add new inline JS exclusion from combine JS (PR #3683) * Ignore Pinterest ads "pp" query string when serving the cache (PR #3682) * Fix double space in renewal banner copy (PR #3674) * Exclude reload_attached_coupons from combine JS (PR #3671) * Exclude arf_footer_cl_logic_call from combine JS (PR #3665) * Fix rest API tests fixtures (PR #3688) * add details attribute to error data * remove details attribute from error data and use assertArraySubset to make sure that needed attributes are there * adjust the GH workflow to use WP 5.7 * adjust the GH workflow to use latest WP version always for non legacy * Exclude nonce actions for Discount Rules and Dynamic Pricing for WooCommerce (PR #3679) * update fixtures after typo fix * Closes #3230 Add PHP 8 to our CI matrix (PR #3656) * add PHP 8 to our CI matrix * update composer configuration * update phpstan-wp dependency version * update phpunit package version * update workflows * only bailout if the provided structure is not empty * update return typehint for setUp() and setUpBeforeClass() * use Mockery for mocks instead of phpunit mocks * remove separate process * update version to 3.9-alpha1 * v3.8.6 (#3623) * Update wording in first activation notice on the dashboard (PR #3583) Add automatically to match the description on the website. Also without it it sounds like WP Rocket would not know how to deal with the remaining 20%. * Fixes #3590 Imagify icon not shown in Chrome (PR #3591) * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in de_DE translation completed updated for the source file '/languages/rocket.pot' on the 'de_DE' language. * Fixes #3498 Turn off "Delay JS" option when Safe Mode is activated (PR #3574) * Fixes #3454 Delay JS is not working if scrolling the page with the mouse wheel (PR #3573) * Closes #2839 Remove Age Verify plugin compatibility files (PR #3585) * Closes #1744 Show warning when PageSpeed Ninja is active (PR #3580) * Fixes #3238 Remove empty values in $purge_urls array (PR #3579) * Fixes #2777 Update text formatting in Rocket Analytics modal (#3598) * Closes #3113 Stop removing empty lines in the .htaccess (PR #3599) * Fixes #3605 Replace deprecated jQuery methods (PR #3606) * Translate /languages/rocket.pot in ru_RU translation completed for the source file '/languages/rocket.pot' on the 'ru_RU' language. * Closes #3564 Update minified filename structure to use query string instead of version in filename (PR #3595) * Fixes #3083 Update delay JS RegEx to ignore space inside script tags (PR #3587) * Updating AWX webhook url * Fixes #3576 Guard rocket_defer_inline_exclusions filter return when used by 3rd parties (PR #3582) * Fixes #2970 Add new post-type exclusion "cms_block" from CPCSS generation (PR #3550) * Closes #3423 Add preconnect tag for CDN URLs (#3463) * Add add_preconnect_cdn() method * Add integration test draft and notes. * Implement preconnect for non-crossorigin cdn-urls * Add fixture, adjust integration test * Revise forcorrect cdn urls, use crossorigin second * Run phpcbf * Update CDN preconnect testcases * Use agnostic scheme when not provided * Rerun phpcs * Clean dns-prefetch out of testcases :) * Add testcase/solution for `test/tests` * Closes #3539 Combine @import rules into the minified CSS files (PR #3603) * update plugin version * update pot file with changed strings * Translate /languages/rocket.pot in de_DE translation completed for the source file '/languages/rocket.pot' on the 'de_DE' language. * Translate /languages/rocket.pot in fr_FR translation completed for the source file '/languages/rocket.pot' on the 'fr_FR' language. * Fix #3625 Contact form 7 stop working if dependency scripts are deferred after latest update (PR #3629) * exclude files from being deferred * add hooks script to the exclude list * update translations * Translate /languages/rocket.pot in tr_TR translation completed for the source file '/languages/rocket.pot' on the 'tr_TR' language. Co-authored-by: Presskopp <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Jonathan Buttigieg <[email protected]> Co-authored-by: Jorge <[email protected]> Co-authored-by: Natalia Drause <[email protected]> Co-authored-by: Caspar Green <[email protected]> Co-authored-by: Ahmed Saed <[email protected]> Co-authored-by: Vasilis Manthos <[email protected]> Co-authored-by: Albert Cintas <[email protected]> Co-authored-by: Sandy Figueroa <[email protected]> Co-authored-by: Soponar Cristina <[email protected]> * Add integration test for Warmup\APIClient * Adjust Warmup\APIClient fixture * Adjust Warmup\APIClient unit test w/new fixture * Add integration test Frontend\APIClient * Modify Frontend\APIClient fixture for new test. * Fix warmup APIClient fixture WPError case * Add remaining testcases for Frontend APIClient * Use actual returmed error codes in APIClients * Refactor check_response() * Refactor Unit tests for new Fixture * Clean up fixture * Refactor Warmup API Unit test for check_response() * Restore odd removals * Don’t alias Brain\Monkey\Functions Co-authored-by: Vasilis Manthos <[email protected]> Co-authored-by: Albert Cintas <[email protected]> Co-authored-by: Ahmed Saed <[email protected]> Co-authored-by: Sandy Figueroa <[email protected]> Co-authored-by: Rémy Perona <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Adame Dahmani <[email protected]> Co-authored-by: Jorge <[email protected]> Co-authored-by: Scott Hartley <[email protected]> Co-authored-by: Natalia Drause <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rémy Perona <[email protected]> Co-authored-by: Presskopp <[email protected]> Co-authored-by: Jonathan Buttigieg <[email protected]> Co-authored-by: Soponar Cristina <[email protected]> Co-authored-by: Cristina Soponar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add delay JS to the list of options to turn off when safe mode is enabled.
Closes #3498
Type of change
Is the solution different from the one proposed during the grooming?
No
Checklist: